SG-38306 Python2 Removal - Part 9 - six module #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoChaucaGallegos
changed the title
eduardoChaucaGallegos
force-pushed
the
SG-38306-python2-removal-six
branch
2 times, most recently
from
72a8750 to
733f058
Compare
julien-lang
changed the title
julien-lang
force-pushed
the
SG-38306-python2-removal-six
branch
2 times, most recently
from
24ce878 to
4961679
Compare
julien-lang
changed the base branch from
master
to
ticket/SG-38306-python2-ensure-ascii
julien-lang
changed the title
julien-lang
changed the title
This was referenced Jul 16, 2025
Open
julien-lang
force-pushed
the
ticket/SG-38306-python2-ensure-ascii
branch
from
2f109c4 to
f6275cd
Compare
julien-lang
force-pushed
the
SG-38306-python2-removal-six
branch
from
4961679 to
9a131fa
Compare
julien-lang
reviewed
Jul 17, 2025
There was a problem hiding this comment.
That's only possible if shotgunsoftware/tk-core#1042 is merged and released first
There was a problem hiding this comment.
Pull Request Overview
This PR removes Python 2 compatibility code as part of the larger Python 2 removal effort, specifically targeting the six module and related utility functions. The changes clean up legacy compatibility layers that are no longer needed since the project has moved to Python 3 only.
Key changes:
- Removed the bundled
sixmodule and related imports from test and production code - Deleted the custom
sgutils.pyandsgsix.pycompatibility modules - Replaced
six.PY38version checks with directsys.version_infocomparisons - Updated configuration files to exclude removed modules from linting and coverage
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shotgun_api3/shotgun.py | Replaced six.PY38 checks with sys.version_info comparisons and removed six/sgutils imports |
| shotgun_api3/lib/six.py | Complete removal of the bundled six compatibility library |
| shotgun_api3/lib/sgutils.py | Removed custom utility functions for Python 2/3 compatibility |
| shotgun_api3/lib/sgsix.py | Removed Shotgun-specific six extensions module |
| tests/*.py | Cleaned up six imports from test files |
| Configuration files | Updated flake8 and coverage exclusions to remove references to deleted modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR orders